No need to handle if FrozenError is available #34778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahonda
force-pushed
the
ruby25_frozen_error
branch
from
a26c2d5 to
e5d5e0c
Compare
y-yagi
reviewed
Dec 23, 2018
| @@ -314,7 +314,7 @@ def test_query_cache_does_not_allow_sql_key_mutation | |||
| payload[:sql].downcase! | |||
| end | |||
|
|
|||
| assert_raises frozen_error_class do | |||
| assert_raises RuntimeError do | |||
yahonda
force-pushed
the
ruby25_frozen_error
branch
from
e5d5e0c to
09ea58e
Compare
rails-bot
bot
added
actioncable
actionmailer
actionpack
actionview
activejob
activemodel
labels
|
Rebased incorrectly. Let me address it. |
Rails 6 requires Ruby 2.5, which introduces `FrozenError` https://docs.ruby-lang.org/en/2.5.0/NEWS.html Related to rails#31520
yahonda
force-pushed
the
ruby25_frozen_error
branch
from
09ea58e to
05781f1
Compare
|
Rebased. Because of my previous incorrect rebase, these labels should be removed.
|
|
I dig it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rails 6 requires Ruby 2.5, which introduces
FrozenErrorhttps://docs.ruby-lang.org/en/2.5.0/NEWS.htmlRelated to #31520