New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare Trix as peer dependency of Action Text's npm package #34958

Merged
merged 2 commits into from Jan 17, 2019

Conversation

Projects
None yet
3 participants
@javan
Copy link
Member

javan commented Jan 17, 2019

  1. Change trix from a dependency to a peer dependency since Trix isn't used directly by @rails/actiontext
  2. Tidy up the action_text:install task to install both @rails/actiontext and trix using the versions specified in package.json

javan added some commits Jan 17, 2019

Tidy up action_text:install task
Automate installing the appropriate packages with yarn and appending them to the default application.js pack.

@rails-bot rails-bot bot added the actiontext label Jan 17, 2019

@@ -1,3 +1,13 @@
require "pathname"

This comment has been minimized.

@rafaelfranca

rafaelfranca Jan 17, 2019

Member

Should this installer still exists? Is not the idea to generate the application and already get actiontext on it like the other frameworks like actioncable?

cc @dhh

This comment has been minimized.

@javan

javan Jan 17, 2019

Author Member

I'm not sure, TBH. Active Storage needs to be installed first, which requires running rails active_storage:install (I think?).

Any reason not to merge this in the meantime?

This comment has been minimized.

@rafaelfranca

rafaelfranca Jan 17, 2019

Member

I think we can make that work. Not a blocker for this PR, just asking because this may be something we need to change before the beta2.

This comment has been minimized.

@dhh

dhh Jan 17, 2019

Member

Yes, the idea is still that this requires running a task if you actually want to use it in the app. Since we do migrations and stuff. Just like active storage. But that everything is already there. Nothing to configure or setup or add dependencies for. Just a single task to run.

@javan javan merged commit 69c963c into rails:master Jan 17, 2019

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@javan javan deleted the javan:actiontext/trix-as-peer branch Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment