Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Zeitwerk be a dependency of Active Support #35261

Merged
merged 1 commit into from Feb 14, 2019

Conversation

Projects
None yet
2 participants
@fxn
Copy link
Member

fxn commented Feb 13, 2019

As discussed with @matthewd in #35235.

In this alternative, we require the library as soon as config.autoloader is set to :zeitwerk. I have restored the single quotes in the Gemfile template too.

Let Zeitwerk be a dependency of Active Support
Zeitwerk is a strong dependency, planned to replace AS::Dependencies. A
line in the generated Gemfile does not convey this as much.

@fxn fxn requested a review from matthewd Feb 13, 2019

@fxn fxn merged commit a20b00d into master Feb 14, 2019

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fxn fxn deleted the zeitwerk-as-dependency branch Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.