Add defaults option to ActiveRecord::InsertAll.

[simi]

mainly extracted from #35494

If same key is used in data hash and also in defaults, data hash one is used.

I'll update documentation once approved.

[boblail]

LGTM! 🙂

👍I like how you did this without a second loop through all the inserts

[simi]

@boblail 👀 changes addressed.

[boblail]

🤔 What if we didn't add :defaults at all? What if — instead of

🅰️

Book.insert_all(data, defaults: { created_at: Time.now, updated_at: Time.now })

we used create_with according to your PR, #35638, to do:

🅱️

Book.create_with(created_at: Time.now, updated_at: Time.now).insert_all(data)

The behavior will be slightly different. 🅰️ would allow a record in data to override the merged timestamps; 🅱️ will give precedence to the values given in create_with.

However, I think it accomplishes the same goal, adds fewer arguments to insert_all, and it'd be my personal preference to use create_with over defaults: anyway.

[simi]

good idea @boblail

[kaspth]

After thinking about it more, I came to the same conclusion as @boblail that we shouldn't add defaults, but go with where.

E.g. Post.where(created_at: Time.now).insert_all(posts).

Yes, we should also support create_with and it should only be merged in for inserts (and not updates) when using upsert_all.

Thanks!

[alex-benoit]

Can the conclusion of the discussion/what is planned for Rails 6 be posted on the open issue here as well 🙏 @kaspth
#35493

[kaspth]

Rails 6 has hit its feature freeze, so there’s no further feature development scheduled for 6.0