Add attribute_names to ActiveModel::Attributes #36059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
composerinteralia
force-pushed
the
model-attribute-names
branch
from
76f766a to
882721d
Compare
This adds `.attribute_names` and `#attribute_names` to `ActiveModel::Attributes` along the same lines as the corresponding methods in `ActiveRecord::AttributeMethods` (see [`.attribute_names`][class_method] and [`#attribute_names`][instance_method]. While I was here I also added documentation for '#attributes', which I added in 043ce35. The whole class is still `#:nodoc:` so I don't think this will have any effect for now. [class_method]: https://github.com/rails/rails/blob/cc834db1d0815744cfa173813c05d928e008e167/activerecord/lib/active_record/attribute_methods.rb#L154-L160 [instance_method]: https://github.com/rails/rails/blob/cc834db1d0815744cfa173813c05d928e008e167/activerecord/lib/active_record/attribute_methods.rb#L299-L301
composerinteralia
force-pushed
the
model-attribute-names
branch
from
882721d to
e7a28c3
Compare
Writing the high level documentation, reviewing the low level documentation and the API to see if there is something missing. Nobody is working on that right now so if you want that would be helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No rush on reviewing this PR. This can definitely wait until after the next release
This adds
.attribute_namesand#attribute_namestoActiveModel::Attributesalong the same lines as the corresponding methods inActiveRecord::AttributeMethods(see.attribute_namesand#attribute_names).While I was here I also added documentation for
#attributes, which I added in 043ce35. The whole module is still#:nodoc:so I don't think this will have any effect for now.I do have questions about future plans for
ActiveModel::Attributes. Is there something in particular that is holding us back documenting this publicly (7e9ded5 mentions that it was not ready yet, but I don't know exactly what is missing)? I have used it successfully on a few projects, not quite realizing is wasn't documented. If there are specific things that we need to work on I would be happy to take that on.