Allow on_rotation in MessageEncryptor to be passed in constructor:
#36270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsWill
reviewed
May 14, 2019
Edouard-chin
force-pushed
the
ec-on-rotation-constructor
branch
2 times, most recently
from
ac1a51f to
59c20fd
Compare
|
cc/ @rafaelfranca (since I know you declared bankruptcy on notifications recently 😄) |
kaspth
reviewed
May 26, 2019
|
I'm curious what you're doing in |
|
thanks for the feedbacks, pushed a new commit.
Yeah just passing data to statsd to know when the old secrets is no longer used. |
Edouard-chin
force-pushed
the
ec-on-rotation-constructor
branch
2 times, most recently
from
8b8e0a5 to
95e9974
Compare
kaspth
approved these changes
Jun 6, 2019
There was a problem hiding this comment.
Now we just got to get a passing build.
I've been trying to rebuild but then the checkout fails https://buildkite.com/rails/rails/builds/61568#_
|
Thanks I'll try to amend/force push a bit later today. Might just be some network blips |
- Use case: I'm writing a wrapper around MessageEncryptor to make things easier to rotate a secret in our app. It works something like ```ruby crypt = RotatableSecret.new(['old_secret', 'new_secret']) crypt.decrypt_and_verify(message) ``` I'd like the caller to not have to care about passing the `on_rotation` option and have the wrapper deal with it when instantiating the MessageEncryptor object. Also, almost all of the time the on_rotation should be the same when rotating a secret (logging something or StatsD event) so I think it's not worth having to repeat ourselves each time we decrypt a message.
Edouard-chin
force-pushed
the
ec-on-rotation-constructor
branch
from
95e9974 to
a5502f4
Compare
|
should be good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
on_rotationin MessageEncryptor to be passed in constructor:Use case:
I'm writing a wrapper around MessageEncryptor to make things easier
to rotate a secret in our app.
It currently works something like
I'd like the caller to not have to care about passing the
on_rotationoption and have the wrapper deal with it wheninstantiating the MessageEncryptor object.
Also, almost all of the time the on_rotation should be the same when
rotating a secret (logging something or StatsD event) so I think
it's not worth having to repeat ourselves each time we decrypt a message.