Stop setting a default Capybara app host #36615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileencodes
approved these changes
Jul 14, 2019
rafaelfranca
approved these changes
Jul 16, 2019
It's intended not to be set if Capybara starts the app server itself. Base Rails-generated URLs off of Capybara.current_session.server_url instead.
y-yagi
added a commit
that referenced
this pull request
Sep 6, 2019
System tests depend on Capybara 3.26 or newer. Ref: #36615.
|
Just wanted to say thanks for fixing this, this caused a problem for me a few years back, and today I found that I needed to make a change which wasn't compatible with my workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's intended not to be set if Capybara starts the app server itself. Base Rails-generated URLs off of
Capybara.current_session.server_urlinstead.Closes #36608.
/cc @twalpole