Serialize symbols to strings in ImmutableString serialize method #36907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symbols serialize to strings when persisted:
model.some_string = :foo
model.save! # "foo" is persisted
This PR updates the immutable string class to serialize symbols to strings to mirror this behavior as ActiveModel::Attribute calls this serialize method to determine the return value for changed_in_place? Prior to this change this code would report that "something" had changed:
comment = Comment.create! # (has a string "something" field)
comment.update_column :something, :anything # persists "anything" to the "something" field of the comments table
comment.something # or comment.attributes
comment.something_change # will be ["anything", "anything"], note these are `to` and `from` values, but are identical
After this PR the comment.something_change will return nil for this situation.
Fixes #36463
|
Given that 5.2 and 6.0 now have this current (broken?) behavior, I wonder if this behavior will now be considered as breaking change. Maybe @rafaelfranca or @matthewd can help me decide? |
|
The current behaviour is definitely broken (at least in my mind). I don't think I'd consider it a feature just because it's been around a while. |
|
Seems fair: we often work hard to make symbols and strings interchangeable in contexts where it makes sense, and given that, it seems pretty weird for us to claim a value has changed from & to the same value. |
wjessop
deleted the
string_attribute_should_compare_with_typecast_symbol_after_update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Symbols serialize to strings when persisted:
This PR updates the immutable string class to serialize symbols to strings to mirror this behavior as ActiveModel::Attribute calls this serialize method to determine the return value for changed_in_place? Prior to this change this code would report that "something" had changed:
After this PR the comment.something_change will return nil for this situation.
Fixes #36463
Other Information
I bisected and it looks like c342d58 introduced the change in behavior.