[Needs feedback] Fix n+1 issue of ActionText attachments #36945
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root cause of this issue is that we use globalid to query attachment blobs, which means it can't gain any benefit from preloaded data. So my solution is to preload those blobs and store them into a table. And before using globalid locator to do the search, we perform a lookup in the table with the parsed id. If it's found (which should be most of the cases) then we just return the records. Otherwise, we perform the search via globalid locator.
|
You're certainly further along than I am because you actually have some code. However here's my 2c: I think sgid attachments have two design gotchas worth addressing: N+1, and key rotation. It's a pity because using them in Action Text in this fashion was otherwise pretty slick IMO. As a result, in my head I was thinking of grafting in an optional configuration whereby Action Text references attachments via a UUID and a polymorphic join table instead. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(The current state of this PR is to demonstrate my idea of the solution. So I hope I can get some feedback about the design.)
This PR is for #36177. The issue is that eager loading helpers for ActionText contents doesn't work as expected. Users still get n+1 queries after using helper scope like
The root cause of this issue is that we use globalid to query attachment blobs, which means it can't gain any benefit from preloaded data.
(See more detailed explanation here)
So my solution is to preload those blobs and store them into a table. And before using globalid locator to do the search, we perform a` lookup in the table first. If it's found (which should be most of the cases) then we just return the records. Otherwise, we perform the search via globalid locator.