Fix conditions in ActiveStorage #37018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I first wanted to fix this condition
!attachables.nil? || Array(attachables).any?
since if something is notnil
it will always returntrue
instead of checking if the array has any element. My guess is that this other condition that already existedattachables.nil? || Array(attachables).none?
was tried to be negated unsuccessfully.Then I realised that
Array(nil)
returns[]
so we could simplify the conditions.Notes
Not sure why tests are failing