Skip to content

Conversation

beauraF
Copy link
Contributor

@beauraF beauraF commented Nov 26, 2019

With Rails 6.0.2.1, when you run rails app:update, spring binstub --all is not run when spring is defined. Which lead to spring no longer being integrated into your binaries.


Steps to reproduce

 rails _5.2.3.1_ new foobar
 cd foobar
 cat bin/rake
#!/usr/bin/env ruby
begin
  load File.expand_path('../spring', __FILE__)
rescue LoadError => e
  raise unless e.message.include?('spring')
end
require_relative '../config/boot'
require 'rake'
Rake.application.run
 sed -i -e "s/gem 'rails', '~> 5.2.3.1'/gem 'rails', '6.0.2.1'/" Gemfile
 bundle update rails
 yes | bundle exec rails app:update
 cat bin/rake
#!/usr/bin/env ruby
require_relative '../config/boot'
require 'rake'
Rake.application.run

I just add a call to generate_spring_binstubs in bin_when_updating, that do the trick. :)

@rails-bot rails-bot bot added the railties label Nov 26, 2019
@beauraF beauraF changed the title spring binstub --all not run when rails app:update run spring binstub --all during rails app:update Nov 29, 2019
@yskkin
Copy link
Contributor

yskkin commented Dec 29, 2019

This follows #32525 👍

@beauraF beauraF requested review from y-yagi February 1, 2020 11:11
@beauraF beauraF requested a review from rafaelfranca February 25, 2020 20:17
@rails-bot
Copy link

rails-bot bot commented May 25, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@rails-bot rails-bot bot added the stale label May 25, 2020
@rails-bot rails-bot bot closed this Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants