Check url_for options params is hash before merging it into actual pa…

[simi]

This is based on #33256 (comment) and kaminari/kaminari#1025 (comment).

TL;DR; currently any application re-using params for url_for (as is for example used in popular kaminari gem) explodes when you add manually &params=whatever to url.

before

url_for(only_path: true, controller: "c", action: "a", params: "p")

TypeError: no implicit conversion of String into Hash                       
    /home/retro/code/oss/rails/actionpack/lib/action_dispatch/routing/route_set.rb:829:in `merge!'
    /home/retro/code/oss/rails/actionpack/lib/action_dispatch/routing/route_set.rb:829:in `url_for'
    /home/retro/code/oss/rails/actionpack/lib/action_dispatch/routing/url_for.rb:181:in `full_url_for'
    /home/retro/code/oss/rails/actionpack/lib/action_dispatch/routing/url_for.rb:171:in `url_for'
    /home/retro/code/oss/rails/actionpack/test/controller/url_for_test.rb:366:in `test_params_string_option'

after (it is ignored)

url_for(only_path: true, controller: "c", action: "a", params: "p") #=> "/c/a"

[simi]

ℹ️ I have left some info regarding this (and also another problem) at kaminari original issue as well.

kaminari/kaminari#1025 (comment)

[rails-bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.