IsDistinctFrom is not equality node
#39668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`IsDistinctFrom` which was added at rails#34451 is almost same with `NotEqual`. Historically subclasses of `Equality` has a special ability, it has migrated to `equality?` method, so newer class should implement the method rather than inheriting the `Equality` if want to have an equality ability, at least `IsDistinctFrom` should not be an equality node (actually `IsNotDistinctFrom` is almost same with `Equality`, but I'd not interested to give a special ability to the node which is rarely used).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsDistinctFromwhich was added at #34451 is almost same withNotEqual.Historically subclasses of
Equalityhas a special ability, it hasmigrated to
equality?method, so newer class should implement themethod rather than inheriting the
Equalityif want to have an equalityability, at least
IsDistinctFromshould not be an equality node(actually
IsNotDistinctFromis almost same withEquality, but I'dnot interested to give a special ability to the node which is rarely
used).