Add Time#ceil and Time#floor core extensions.
#39828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
force-pushed
the
backward_patches_for_time_floor_ceil
branch
from
6b1871a to
ae61809
Compare
tgxworld
commented
Jul 13, 2020
|
@pixeltrix This is still a draft while I clarify with the Ruby team regarding |
pixeltrix
reviewed
Jul 13, 2020
tgxworld
force-pushed
the
backward_patches_for_time_floor_ceil
branch
2 times, most recently
from
24ef2b5 to
6acfe66
Compare
tgxworld
force-pushed
the
backward_patches_for_time_floor_ceil
branch
3 times, most recently
from
4a3de70 to
c9b8379
Compare
|
@pixeltrix https://bugs.ruby-lang.org/issues/17025 got fixed in ruby/ruby#3362 so I've marked the PR to be ready for view :) |
tgxworld
force-pushed
the
backward_patches_for_time_floor_ceil
branch
from
c9b8379 to
9230b5b
Compare
tgxworld
changed the title
Time#ceil and Time#floor for Ruby versions < 2.7Time#ceil and Time#floor core extensions.
tgxworld
force-pushed
the
backward_patches_for_time_floor_ceil
branch
from
9230b5b to
5b28ba9
Compare
|
Thank you for reviewing @rafaelfranca and @pixeltrix 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As per the discussion in #39698 (comment)
Other Information