fix: warning: instance variable @controller not initialized #40025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39937
Summary
As described in the #39937,
@controller
is not always defined while testing routes, and thus the linerails/actionpack/lib/action_dispatch/testing/assertions/routing.rb
Line 202 in 23a9e29
might raise
warning: instance variable @controller not initialized
in some instances.This can be handled by checking
defined?(controller)
before accessing the instance variable.Thanks to @ioquatix for the report (and solution as well :) )