Skip to content

Add support for stylesheets and ERB views to rails stats. #40597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2020
Merged

Add support for stylesheets and ERB views to rails stats. #40597

merged 1 commit into from
Nov 23, 2020

Conversation

joelhawksley
Copy link
Contributor

@joelhawksley joelhawksley commented Nov 10, 2020 •
edited
Loading

Summary

In looking for ways to report statistics on the size of GitHub's monolith, I realized that rails stats does not report on the app/views and app/assets/stylesheets directories.

I think folks would find it useful to see stats on these folders. This PR adds them as Views and Stylesheets:

+----------------------+--------+--------+---------+---------+-----+-------+
| Name                 |  Lines |    LOC | Classes | Methods | M/C | LOC/M |
+----------------------+--------+--------+---------+---------+-----+-------+
| Controllers          |      6 |      6 |       2 |       1 |   0 |     4 |
| Helpers              |      2 |      2 |       0 |       0 |   0 |     0 |
| Jobs                 |      2 |      2 |       1 |       0 |   0 |     0 |
| Models               |     35 |     29 |       3 |       6 |   2 |     2 |
| Mailers              |      4 |      4 |       1 |       0 |   0 |     0 |
| Views                |    130 |    127 |       0 |       0 |   0 |     0 |
| JavaScripts          |     16 |      0 |       0 |       0 |   0 |     0 |
| Stylesheets          |     21 |     19 |       0 |       0 |   0 |     0 |
+----------------------+--------+--------+---------+---------+-----+-------+
| Total                |    216 |    189 |       7 |       7 |   1 |    25 |
+----------------------+--------+--------+---------+---------+-----+-------+
  Code LOC: 189     Test LOC: 0     Code to Test Ratio: 1:0.0

@rails-bot rails-bot bot added the railties label Nov 10, 2020
@joelhawksley joelhawksley changed the title add support for views and stylesheets to rails stats Add support for stylesheets and ERB views to rails stats. Nov 10, 2020
@joelhawksley joelhawksley changed the base branch from master to 6-1-stable November 10, 2020 15:54
rafaelfranca
rafaelfranca reviewed Nov 10, 2020
View reviewed changes
Copy link
Member

@rafaelfranca rafaelfranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a small comment about the changelog. Can you squash your commits in only one?

railties/CHANGELOG.md Outdated
* Allow appended root routes to take precedence over internal welcome controller.

*Gannon McGibbon*


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was correct, can you put it back please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do once I figure out this rebase I just messed up ❤️

@joelhawksley joelhawksley marked this pull request as draft November 10, 2020 16:01
@joelhawksley joelhawksley marked this pull request as ready for review November 10, 2020 16:05
@joelhawksley
Copy link
Contributor Author

@rafaelfranca alright, I squashed to a single commit.

I pointed this at 6-1-stable, but happy to point to master if you'd prefer to leave it out of 6.1 ❤️

@kaspth
Copy link
Contributor

kaspth commented Nov 10, 2020

All features go to the master branch and then we backport if suitable.

@joelhawksley joelhawksley changed the base branch from 6-1-stable to master November 10, 2020 16:12
@joelhawksley joelhawksley marked this pull request as draft November 10, 2020 16:12
@joelhawksley joelhawksley marked this pull request as ready for review November 10, 2020 16:15
@joelhawksley
Copy link
Contributor Author

@rafaelfranca @kaspth sorry for all the hassle for such a small PR! This should be all cleaned up now, pointing to master.

@joelhawksley
Copy link
Contributor Author

Fixing the failing test now.

@joelhawksley
Copy link
Contributor Author

@rafaelfranca fixed!

@joelhawksley
Copy link
Contributor Author

@rafaelfranca this should be good to go ❤️

@kaspth kaspth merged commit 4e17c7b into rails:master Nov 23, 2020
@kaspth
Copy link
Contributor

kaspth commented Nov 23, 2020

Sweet, thanks @joelhawksley!

@joelhawksley joelhawksley deleted the view-stats branch November 23, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelfranca rafaelfranca Awaiting requested review from rafaelfranca

Assignees
No one assigned
Labels
actionview activemodel activerecord activesupport railties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joelhawksley @kaspth @rafaelfranca