Fix where with custom primary key for belongs_to association
#40815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a regression for rails#40554.
kamipo
added a commit
that referenced
this pull request
Dec 12, 2020
Fix `where` with custom primary key for belongs_to association
|
FYI this created an issue querying for |
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Dec 27, 2020
It is a regression for rails#40815. If `where` on polymorphic association with non Active Record object, `associated_table.join_primary_key` is called without `klass` in `AssociationQueryValue`, it is wrong usage for polymorphic association. Always use `PolymorphicArrayValue` for polymorphic association to avoid the issue. Fixes rails#40937.
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Jan 12, 2021
Similar to rails#40809 which is fixed by rails#40815, but it is caused by dbda5fe. `value.id if value.respond_to?(:id)` is not always correct if primary key is customized on the belongs_to association. Use `reflection.join_primary_key` in that case. Fixes rails#41081.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a regression for #40554.
Fixes #40809.