Skip to content

Conversation

le0pard
Copy link
Contributor

@le0pard le0pard commented Sep 16, 2021

Summary

Currently tag helper works incorrectly for unpaired svg tags - it always add close pair to its.

Example:

tag.svg { tag.use("href" => "#cool-icon") }

Before:

<svg><use href="#cool-icon"></use></svg>

After:

<svg><use href="#cool-icon"></svg>

@rails-bot rails-bot bot added the actionview label Sep 16, 2021
@rafaelfranca rafaelfranca merged commit 6e2247e into rails:main Sep 20, 2021
@le0pard le0pard deleted the fix_use_tag branch September 20, 2021 21:34
@le0pard
Copy link
Contributor Author

le0pard commented Sep 20, 2021

Thanks @rafaelfranca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants