Enable Lint/DuplicateMethods rubocop rule #43374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvasilevski
force-pushed
the
enable-duplicate-methods-name-cop
branch
from
1d6eb71 to
b725cdc
Compare
nvasilevski
force-pushed
the
enable-duplicate-methods-name-cop
branch
from
b725cdc to
2a00c89
Compare
koic
added a commit
to koic/oracle-enhanced
that referenced
this pull request
Nov 17, 2021
Follow up to rails/rails#43374.
koic
added a commit
to koic/rubocop-rails_config
that referenced
this pull request
Nov 17, 2021
Follow up to rails/rails#43374.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recently I made a mistake by defining two tests with the same name - #43299
I would like to prevent this from happening in the future and the most obvious solution that comes to mind is rubocop.
However please feel free to suggest any other solutions or raise a concern if doesn't make sense to prevent similar errors at all
Thanks!
Solution
I had to disable rubocop for several legitimate cases and removed one actual duplication