Make ActionDispatch::Routing::RouteWrapper class private since it's o… #43451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignacio-chiazzo
force-pushed
the
ig/action_dispatch/inspector
branch
from
3889958 to
f5ac6fc
Compare
|
Thank you. We don't make constants private in Rails. It doesn't add much and just make harder to change the code. |
ignacio-chiazzo
force-pushed
the
ig/action_dispatch/inspector
branch
from
f5ac6fc to
4bb3ace
Compare
ignacio-chiazzo
force-pushed
the
ig/action_dispatch/inspector
branch
from
927efbd to
735a341
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nly used within Routing module.
Summary
While working on this issue I noticed that the class
ActionDispatch::Routing::RouteWrapperwas only used withinRoutingmodule as a decorator forroute. I made itprivate so we don't use that module outside.no-doc