Allow column name with COLLATE as safe SQL string #44384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shugo
force-pushed
the
order_with_collate
branch
from
a4f98a1 to
957d31f
Compare
byroot
approved these changes
Feb 12, 2022
shugo
force-pushed
the
order_with_collate
branch
from
957d31f to
d12e4da
Compare
|
@byroot |
aidanharan
added a commit
to rails-sqlserver/activerecord-sqlserver-adapter
that referenced
this pull request
Sep 13, 2023
aidanharan
added a commit
to rails-sqlserver/activerecord-sqlserver-adapter
that referenced
this pull request
Sep 14, 2023
lavika
pushed a commit
to lavika/activerecord-sqlserver-adapter
that referenced
this pull request
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Functions in the argument of ORDER BY is allowed now (#36448).
COLLATE should also be allowed.
Other Information
It seems that PostgreSQL requires quotes for collation names while MySQL and SQLite doesn't.