Fix setting trailing_slash: true in route definition
#44434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: rails#43287 Fix: rails#44373 The `OptimizedUrlHelper` wasn't considering this option.
casperisfine
commented
Feb 15, 2022
| @@ -196,7 +196,9 @@ def initialize(route, options, route_name) | |||
| def call(t, method_name, args, inner_options, url_strategy) | |||
| if args.size == arg_size && !inner_options && optimize_routes_generation?(t) | |||
| options = t.url_options.merge @options | |||
| options[:path] = optimized_helper(args) | |||
| path = optimized_helper(args) | |||
There was a problem hiding this comment.
Unless I missed something, we know for sure that path doesn't contain a format at this point.
|
This will be backported to cc @WaKeMaTTa, @nvasilevski, @ghiculescu (thanks for the ping, I totally didn't see the issue). |
|
Some unrelated Active Support tests flaked, I'll have to look into them. |
|
Backported in 7-0-stable as 3b59b09 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #43287
Fix: #44373
The
OptimizedUrlHelperwasn't considering this option.