Support :urlsafe option for MessageEncryptor
#45473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to rails#43924. This commit refactors the logic around assembling and extracting the parts of a message (namely: the encrypted data, the IV, and the auth tag). It also provides a small but reproducible performance increase for a roundtrip. Benchmark: ```ruby require "benchmark/ips" require "active_support/message_encryptor" DATA = "x" * 100 ENCRYPTOR = ActiveSupport::MessageEncryptor.new(SecureRandom.random_bytes(32)) Benchmark.ips do |x| x.report("roundtrip") do ENCRYPTOR.decrypt_and_verify(ENCRYPTOR.encrypt_and_sign(DATA)) end end ``` Before: ``` Warming up -------------------------------------- roundtrip 1.342k i/100ms Calculating ------------------------------------- roundtrip 13.525k (± 1.5%) i/s - 68.442k in 5.061532s ``` After: ``` Warming up -------------------------------------- roundtrip 1.409k i/100ms Calculating ------------------------------------- roundtrip 14.125k (± 1.4%) i/s - 71.859k in 5.088419s ```
jonathanhefner
force-pushed
the
message_encryptor-urlsafe-option
branch
from
8505a4b to
85b7a8a
Compare
This adds a `:urlsafe` option to the `MessageEncryptor` constructor. When enabled, this option ensures that messages use a URL-safe encoding. This matches the `MessageVerifier` `:urlsafe` option added in rails#45419.
jonathanhefner
force-pushed
the
message_encryptor-urlsafe-option
branch
from
85b7a8a to
d982332
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is split into two related but separate commits:
The 1st commit refactors
MessageEncryptorto make the 2nd commit simpler, and provide a small performance increase.The 2nd commit adds support for
urlsafe: truetoMessageEncryptor, a laMessageVerifiersince #45419.