Keep rescue template paths in an array #46120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
approved these changes
Sep 23, 2022
Gotta be honest, this is so I can make some hacks. Basically I would like an engine to specify where to find rescue templates, and currently there's no way to add search paths to the debug view lookup context. This commit turns the template path in to an array (that I plan to mutate, but nobody should do that besides me until we make an actual good API). I added the `dup` in `initialize` so in case the array is accidentally mutated we don't leak memory.
tenderlove
force-pushed
the
rescue-template-paths
branch
from
2deb8fc to
5c6e9d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gotta be honest, this is so I can make some hacks. Basically I would like an engine to specify where to find rescue templates, and currently there's no way to add search paths to the debug view lookup context. This commit turns the template path in to an array (that I plan to mutate, but nobody should do that besides me until we make an actual good API).
I added the
dupininitializeso in case the array is accidentally mutated we don't leak memory.