Add ActiveSupport.deprecator
#46337
Merged
Add ActiveSupport.deprecator
#46337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds `ActiveSupport.deprecator` and replaces all usages of `ActiveSupport::Deprecation.warn` in `activesupport/lib` with `ActiveSupport.deprecator`. Additionally, this commit adds `ActiveSupport.deprecator` to `Rails.application.deprecators` so that it can be configured using e.g. `config.active_support.report_deprecations`.
jonathanhefner
force-pushed
the
active_support-deprecator
branch
from
7f4fd91 to
587c340
Compare
jonathanhefner
added a commit
to jonathanhefner/rails
that referenced
this pull request
Nov 9, 2022
Follow-up to rails#46330 and rails#46337. This adds a deprecator arg to some `assert_not_deprecated` calls that were missed in rails#46330 and rails#46337.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
ActiveSupport.deprecatorand replaces all usages ofActiveSupport::Deprecation.warninactivesupport/libwithActiveSupport.deprecator.Additionally, this commit adds
ActiveSupport.deprecatortoRails.application.deprecatorsso that it can be configured using e.g.config.active_support.report_deprecations.