Add link to Rollback in transactions doc. #46414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A common misconception with transaction rollback in Rails is that exceptions will not be re-raised from nested transactions. This is only true for ActiveRecord::Rollback. The documentation for that class makes that clear. A link to that class doc has been added, as well as an explicit restatement that all other exceptions will be re-raised.
|
Thanks @dersam ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
A common misconception with transaction rollback in Rails is that exceptions will not be re-raised from nested transactions. This is only true for
ActiveRecord::Rollback. The documentation for that class makes that clear.Detail
A link to that class doc has been added in
Transactions::ClassMethods, as well as an explicit restatement that all other exceptions will be re-raised.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]