ActiveSupport::CurrentAttributes: raise if a restricted attribute name is used.
#47017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame is used. Attributes such as `set` and `reset` should not be used as they clash with the `CurrentAttributes` public API. This PR raises an `ArgumentError` if a restricted attribute name is used.
ghiculescu
force-pushed
the
current-attributes-restricted-names
branch
from
6b92328 to
1284df5
Compare
|
This might be a breaking change (but anyone relying on it would have not had current attributes work properly), so maybe a deprecation is needed? |
|
I don't think a warning is needed, as like you point out, it would have been broken in various ways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attributes such as
setandresetshould not be used as they clash with theCurrentAttributespublic API. This PR raises anArgumentErrorif a restricted attribute name is used.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]