Support string or symbol for owner_name #47424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In legacy systems the `owner_name` didn't have to be a class so it's possible that connections are using a string as an identifier. I think this should be allowed since we turn it into a class that defines the necessary methods that are called on the connection class object (like `primary_class?` and `preventing_writes?`. Before, `owner_name` had to be a class so any application wanting to use a special identifier would be forced to use `ActiveRecord::Base` or ensure their `config` was a `Symbol`. With this change, you can pass a `db_config` object and a string to use for the owner OR you can pass a symbol and still define a custom owner. In some cases you might not want the name to default to the symbol version of your config name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In legacy systems the
owner_namedidn't have to be a class so it's possible that connections are using a string as an identifier. I think this should be allowed since we turn it into a class that defines the necessary methods that are called on the connection class object (likeprimary_class?andpreventing_writes?.Before,
owner_namehad to be a class so any application wanting to use a special identifier would be forced to useActiveRecord::Baseor ensure theirconfigwas aSymbol. With this change, you can pass adb_configobject and a string to use for the owner OR you can pass a symbol and still define a custom owner. In some cases you might not want the name to default to the symbol version of your config name.