Fix for SQLite binary data corrupter (to master branch) #4809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenderlove
added a commit
that referenced
this pull request
Feb 1, 2012
Fix for SQLite binary data corrupter (to master branch)
tenderlove
added a commit
that referenced
this pull request
Feb 2, 2012
Fix for SQLite binary data corrupter (to master branch)
|
You are crazy guys! You haven't even mentioned such an important change on the changelog! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #4777 for the SQLite adapter which will corrupt binary data if the data contains '%00'. I've provided a test which fails without the fix and passes after the fix.
I've applied this patch against the master branch (instead of the 3-2-stable branch as in issue #4778).
Please let me know if there are any other changes I need to make.
Thanks!
Chris