Deprecate params via :args for assert_enqueued_email_with
#48194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
In rails#45752, a `:params` kwarg was added to `assert_enqueued_email_with` so that mailer params and args could be specified simultaneously. However, for backward compatibility, the old behavior of treating an `:args` Hash as params was preserved. The result is that if both `:params` and `:args` are specified and `:args` is a Hash, `:params` is ignored. This commit deprecates specifying params via `:args` (i.e. passing a Hash to `:args`). After the deprecated behavior is removed, it will be possible to pass a Hash to `:args`, and the Hash will be treated as named args instead.
jonathanhefner
force-pushed
the
assert_enqueued_email_with-deprecate-params-via-args
branch
from
a2564f1 to
19df946
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #45752, a
:paramskwarg was added toassert_enqueued_email_withso that mailer params and args could be specified simultaneously. However, for backward compatibility, the old behavior of treating an:argsHash as params was preserved. The result is that if both:paramsand:argsare specified and:argsis a Hash,:paramsis ignored.This commit deprecates specifying params via
:args(i.e. passing a Hash to:args).After the deprecated behavior is removed, it will be possible to pass a Hash to
:args, and the Hash will be treated as named args instead.