update ERB::Util.html_escape_once
to always return an html_safe
string
#48265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This PR updates the behavior of
ERB::Util.html_escape_once
to always return anhtml_safe
string.This method previously maintained the
html_safe?
property of a string on the return value. Because this string has been escaped, however, not marking it ashtml_safe
causes entities to be double-escaped.As an example, take this view snippet:
Before this change, that would be double-escaped and render as:
After this change, it renders correctly as:
Fixes #48256
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]