Deprecate active_support.cache_format_version = 6.1 #48598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once we finally get rid of it, we're no longer constrained on the `Entry` internal representation as other coders don't directly marshal the instance.
4 tasks
yahonda
added a commit
to yahonda/rails
that referenced
this pull request
Aug 25, 2023
…ltieTest` This commit suppresses the `DEPRECATION WARNING: Support for `config.active_support.cache_format_version = 6.1` has been deprecated and will be removed in Rails 7.2.` warning at `RailtieTest` This commit sets `config.active_support.cache_format_version = 7.1` explicitly for `RailtieTest` because rails#48598 deprecates `active_support.cache_format_version = 6.1` and still the default format_version is 6.1, I think this is intended. https://github.com/rails/rails/blob/4ac237de74a1ff383a44f6dc04c0e8894633722b/activesupport/lib/active_support/cache.rb#L55 ``` @format_version = 6.1 ``` \### Steps to reproduce ``` git clone https://github.com/rails/rails cd rails/activemodel bundle bin/test test/cases/railtie_test.rb:21 ``` \### Without this commit ``` $ bin/test test/cases/railtie_test.rb:21 Run options: --seed 36872 \# Running: DEPRECATION WARNING: Support for `config.active_support.cache_format_version = 6.1` has been deprecated and will be removed in Rails 7.2. Check the Rails upgrade guide at https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#new-activesupport-cache-serialization-format for more information on how to upgrade. (called from block (3 levels) in run at /home/yahonda/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/minitest-5.19.0/lib/minitest/test.rb:94) . Finished in 0.321429s, 3.1111 runs/s, 3.1111 assertions/s. 1 runs, 1 assertions, 0 failures, 0 errors, 0 skips $ ``` \### With this commit ``` $ bin/test test/cases/railtie_test.rb:21 Run options: --seed 65282 \# Running: Finished in 0.006108s, 0.0000 runs/s, 0.0000 assertions/s. 0 runs, 0 assertions, 0 failures, 0 errors, 0 skips $ ```
4 tasks
paulreece
pushed a commit
to paulreece/rails-paulreece
that referenced
this pull request
Aug 26, 2023
…ltieTest` This commit suppresses the `DEPRECATION WARNING: Support for `config.active_support.cache_format_version = 6.1` has been deprecated and will be removed in Rails 7.2.` warning at `RailtieTest` This commit sets `config.active_support.cache_format_version = 7.1` explicitly for `RailtieTest` because rails#48598 deprecates `active_support.cache_format_version = 6.1` and still the default format_version is 6.1, I think this is intended. https://github.com/rails/rails/blob/4ac237de74a1ff383a44f6dc04c0e8894633722b/activesupport/lib/active_support/cache.rb#L55 ``` @format_version = 6.1 ``` \### Steps to reproduce ``` git clone https://github.com/rails/rails cd rails/activemodel bundle bin/test test/cases/railtie_test.rb:21 ``` \### Without this commit ``` $ bin/test test/cases/railtie_test.rb:21 Run options: --seed 36872 \# Running: DEPRECATION WARNING: Support for `config.active_support.cache_format_version = 6.1` has been deprecated and will be removed in Rails 7.2. Check the Rails upgrade guide at https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#new-activesupport-cache-serialization-format for more information on how to upgrade. (called from block (3 levels) in run at /home/yahonda/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/minitest-5.19.0/lib/minitest/test.rb:94) . Finished in 0.321429s, 3.1111 runs/s, 3.1111 assertions/s. 1 runs, 1 assertions, 0 failures, 0 errors, 0 skips $ ``` \### With this commit ``` $ bin/test test/cases/railtie_test.rb:21 Run options: --seed 65282 \# Running: Finished in 0.006108s, 0.0000 runs/s, 0.0000 assertions/s. 0 runs, 0 assertions, 0 failures, 0 errors, 0 skips $ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #48586
Once we finally get rid of it, we're no longer constrained on the
Entryinternal representation as other coders don't directly marshal the instance.