Skip to content

Improve AR Encryption docs #48728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2023
Merged

Improve AR Encryption docs #48728

merged 1 commit into from
Jul 18, 2023

Conversation

ghiculescu
Copy link
Member

Before:

image

  • Moves the code example directly below where it's referenced, and the note about naming after it.
  • Adds a code example for the other config mentioned.

@rails-bot rails-bot bot added the docs label Jul 13, 2023
@ghiculescu ghiculescu requested a review from jorgemanrubia July 13, 2023 06:31
jorgemanrubia
jorgemanrubia approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@jorgemanrubia jorgemanrubia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ghiculescu

@ghiculescu ghiculescu added the ready PRs ready to merge label Jul 13, 2023
@yahonda yahonda merged commit 93453aa into rails:main Jul 18, 2023
@ghiculescu ghiculescu deleted the patch-11 branch July 18, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jorgemanrubia jorgemanrubia jorgemanrubia approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
docs ready PRs ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghiculescu @jorgemanrubia @yahonda