Prevent inspecting transmit data if not necessary #48772
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Currently on every call to
ActionCable::Channel::Base#transmit
, debug log message is generated that inspects the provideddata
object. The message is generated even if the logger's level is aboveWARN
. This patch makes it so the message is generated only when it can be logged.Detail
In a very similar scenario in
ActionCable::Server::Broadcasting::Broadcaster#broadcast
debug method with a block is used. To use the same call inActionCable::Channel::Base#transmit
, TaggedLoggerProxy must pass block to the wrapped logger.Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]