Document response.parsed_body in 7.1 release notes
#49001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
html-parsed-body-release-notes
branch
from
5355045 to
3a873f6
Compare
seanpdoyle
commented
Aug 22, 2023
| @@ -65,6 +65,43 @@ TODO: https://github.com/rails/rails/pull/45602 | |||
|
|
|||
| TODO: https://github.com/rails/rails/pull/46049 | |||
|
|
|||
| ### Extend `response.parsed_body` to parse HTML with Nokogiri | |||
There was a problem hiding this comment.
@rafaelfranca is this content appropriate for an addition to the 7.1 release notes?
There was a problem hiding this comment.
Would this be better suited as two separate PRs?
- Add Release Notes for the original work done in
ActionDispatch::Testing::TestResponse#parsed_bodyparse HTML with Nokogiri #47144 - Add test coverage for pattern matching, then expand on the Release Notes
There was a problem hiding this comment.
I'll review this list later, since this is a highlight sections, but I prefer to have more and remove than have fewer things and trying to chase in more than 1000s commits
seanpdoyle
force-pushed
the
html-parsed-body-release-notes
branch
from
3a873f6 to
b5d797c
Compare
seanpdoyle
commented
Aug 22, 2023
seanpdoyle
force-pushed
the
html-parsed-body-release-notes
branch
8 times, most recently
from
b772fe1 to
4eb3466
Compare
Add notes for [rails#47144][] to the 7.1 Release Notes. Additionally, in the time since that was merged, both Nokogiri and Minitest have merged the PRs mentioned to integrate support for Ruby's Pattern matching (sparklemotion/nokogiri#2523 and minitest/minitest#936, respectively). This commit adds coverage for those new assertions, and incorporates guidance into the release notes. [rails#47144]: rails#47144
seanpdoyle
force-pushed
the
html-parsed-body-release-notes
branch
from
4eb3466 to
90c9011
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Add notes for #47144 to the 7.1 Release Notes.
Detail
Additionally, in the time since that was merged, both Nokogiri and Minitest have merged the PRs mentioned to integrate support for Ruby's Pattern matching (sparklemotion/nokogiri#2523 and minitest/minitest#936, respectively).
This commit adds coverage for those new assertions, and incorporates guidance into the release notes.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]