Skip to content

[skip ci] ActiveSupport deprecate changes added to 7.1 release note #49119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2023
Merged

[skip ci] ActiveSupport deprecate changes added to 7.1 release note #49119

merged 2 commits into from
Sep 5, 2023

Conversation

akhilgkrishnan
Copy link
Member

This PR updated the deprecate changes of ActiveSupport in the rails 7.1 release note.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the docs label Sep 2, 2023
@akhilgkrishnan
Copy link
Member Author

@rafaelfranca Anything else needs to be added here.

adrianna-chang-shopify
adrianna-chang-shopify reviewed Sep 5, 2023
View reviewed changes
Copy link
Contributor

@adrianna-chang-shopify adrianna-chang-shopify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small suggestion!

@rafaelfranca @adrianna-chang-shopify
Update guides/source/7_1_release_notes.md
f108b65 
Co-authored-by: Adrianna Chang <adrianna.chang@shopify.com>
@rafaelfranca rafaelfranca merged commit 7b8eadb into rails:main Sep 5, 2023
@akhilgkrishnan akhilgkrishnan deleted the activesupport-deprecate-release branch September 6, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianna-chang-shopify adrianna-chang-shopify adrianna-chang-shopify left review comments

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akhilgkrishnan @adrianna-chang-shopify @rafaelfranca