Update doc for include_hidden form form file_field.
#49350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skipkayhil
reviewed
Sep 23, 2023
Update `include_hidden: false` to `include_hidden: true` Update the language to be more accurate. Update actionview/lib/action_view/helpers/form_helper.rb Co-authored-by: Hartley McGuire <skipkayhil@gmail.com>
bhanubhakta
force-pushed
the
bhanubhakta-include-hidden-file-field-docs
branch
from
0cce0b7 to
72b3fe9
Compare
skipkayhil
approved these changes
Sep 25, 2023
|
Thank you for contributing to Rails 🎉 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
The documentation says that the hidden input is only output if include_hidden: true is present. However, it is also output even if the include_hidden key is entirely absent. The documentation does not state that if the
include_hiddenkey is not present it takesconfig.active_storage.multiple_file_field_include_hiddeninto account.include_hiddenis absent.This Pull Request has been created because #48006
Fixes #48006
Checklist
Before submitting the PR make sure the following are checked: