Fix capture view helper for HAML and Slim
#49612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
rafaelfranca
approved these changes
Oct 12, 2023
|
@rafaelfranca I'll add some test tomorrow and backport to 7.1 |
|
👍🏽 I added to the milestone so I don't forget to double check it is merged |
This was referenced Oct 12, 2023
casperisfine
force-pushed
the
action-view-capture-nil-not-blank
branch
from
92c1840 to
4402f66
Compare
Ref: rails#47194 (comment) They both give the buffer as return value of the capture block which confuses the `capture` helper. Ideally we wouldn't have to check for that, but it's an acceptable tradeoff for backward compatibility.
casperisfine
force-pushed
the
action-view-capture-nil-not-blank
branch
from
4402f66 to
79a242d
Compare
byroot
added a commit
that referenced
this pull request
Oct 13, 2023
Fix `capture` view helper for HAML and Slim
|
Backported as c34ddbc |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #47194 (comment)
They both give the buffer as return value of the capture block which confuses the
capturehelper.Ideally we wouldn't have to check for that, but it's an acceptable tradeoff for backward compatibility.