Don't use deprecated #to_default_s in Date#to_fs
#49740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rails 7.1.1, using `Date#to_fs` with an un-exist format, shows the deprecation warning like the following. ```ruby Date.current.to_fs(:doesnt_exist) => DEPRECATION WARNING: to_default_s is deprecated and will be removed from Rails 7.2 (use to_s instead) (called from <main> at ./bin/rails:4) ``` But other date-time-related classes still allow to use this. https://github.com/rails/rails/blob/6f6c211f4781e7bda63e5f47089f9d2612dc0a52/activesupport/lib/active_support/core_ext/time/conversions.rb#L57 https://github.com/rails/rails/blob/6f6c211f4781e7bda63e5f47089f9d2612dc0a52/activesupport/lib/active_support/core_ext/date_time/conversions.rb#L39 So I thought this was just a typo and fixed to use `#to_s` like other classes.
kamipo
added a commit
that referenced
this pull request
Oct 22, 2023
Don't use deprecated `#to_default_s` in `Date#to_fs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detail
In Rails 7.1.1, using
Date#to_fswith an un-exist format, shows the deprecation warning like the following.But other date-time-related classes still allow to use this.
rails/activesupport/lib/active_support/core_ext/time/conversions.rb
Line 57 in 6f6c211
rails/activesupport/lib/active_support/core_ext/date_time/conversions.rb
Line 39 in 6f6c211
So I thought this was just a typo and fixed to use
#to_slike other classes.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]