Improve Action Text System Test coverage #50414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatheusRich
reviewed
Jul 25, 2024
MatheusRich
approved these changes
Jul 25, 2024
Introduce the `ActionText::RichTextEditorTest` to exercise Action Text's integration with Active Storage. First, assert that Action Text renders an Active Storage blob preview of the image within the `<trix-editor>` element prior to persisting the rich-text record. Next, assert that Active Storage renders the uploaded file within the rendered rich-text content. In addition to expanding System Test coverage, this commit also alters the existing `ActionText::SystemTestHelperTest` coverage to utilize Capybara's built-in [:element][] selector as an alternative to CSS. The `:element` selector supports arbitrary keyword arguments as HTML attribute filters. For example, `input: true` as a filter translates to asserting the presence of any `[input]` attribute. Similarly, it enables assertions with Ruby strings instead of interpolating Ruby strings **into** CSS selectors. [:element]: https://rubydoc.info/github/teamcapybara/capybara/master/Capybara/Selector
rafaelfranca
force-pushed
the
action-text-upload-system-test
branch
from
3dfec10 to
a763678
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Introduce the
ActionText::RichTextEditorTestto exercise Action Text's integration with Active Storage. First, assert that Action Text renders an Active Storage blob preview of the image within the<trix-editor>element prior to persisting the rich-text record. Next, assert that Active Storage renders the uploaded file within the rendered rich-text content.Detail
In addition to expanding System Test coverage, this commit also alters the existing
ActionText::SystemTestHelperTestcoverage to utilize Capybara's built-in :element selector as an alternative to CSS. The:elementselector supports arbitrary keyword arguments as HTML attribute filters. For example,input: trueas a filter translates to asserting the presence of any[input]attribute. Similarly, it enables assertions with Ruby strings instead of interpolating Ruby strings into CSS selectors.Additional information
Related to #49527 and #46807.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]