Skip to content

Conversation

koya1616
Copy link
Contributor

@koya1616 koya1616 commented Jan 7, 2024

Motivation / Background

I deleted a FIXME annotation that did not need to be corrected.

Detail

FIXME: is this a desired behavior?

I think YES!

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

Delete `FIXME` in `actionpack/test/dispatch/mapper_test.rb` because it's fixed.
@rails-bot rails-bot bot added the actionpack label Jan 7, 2024
@fatkodima
Copy link
Member

I think YES!

Which behaviour, why it was thought to be incorrect and why do you think it is correct?

@koya1616
Copy link
Contributor Author

koya1616 commented Jan 7, 2024

@fatkodima
I'm sorry for the lack of explanation.

This is about the behavior of the following code. (with / at the end)

mapper.get "/one/two/", to: "posts#index", as: :main

A request for "/one/two/" will be returned as "/one/two(. format)" because it will be converted with the following code.

Journey::Router::Utils.normalize_path(path)

My apologies if I have misunderstood.

FIXME: is this a desired behavior?

Is this question talking about the Ruby on Rails specification? Or is this simply talking about the behavior of the test?

Is it clear? My English is bad. Sorry!

@rafaelfranca rafaelfranca merged commit b6a0fd8 into rails:main Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants