Skip to content

Remove "Migrating from Classic to Zeitwerk" guide [ci-skip] #52156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

p8
Copy link
Member

@p8 p8 commented Jun 19, 2024

Rails 7 apps require running in zeitwerk mode, so we no longer need the migration guide on main, which targets 8.0. The "Autoloading and Reloading Constants" guide also handles autoloading with Zeitwerk, including autoload_paths, the zeitwerk:check command and more.

cc @fxn

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

Rails 7 apps require running in `zeitwerk` mode, so we no longer need
the migration guide. The "Autoloading and Reloading Constants" guide
also handles autoloading with Zeitwerk, including `autoload_paths`, the
`zeitwerk:check` command and more.
@rails-bot rails-bot bot added the docs label Jun 19, 2024
@fxn
Copy link
Member

fxn commented Jun 19, 2024

Good!

@p8 p8 merged commit ab7d62e into rails:main Jun 19, 2024
@p8 p8 deleted the guides/remove-zeitwerk-guide branch June 19, 2024 15:44
@p8
Copy link
Member Author

p8 commented Jun 19, 2024

Thanks @fxn !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants