Skip triggering "instantiation.active_record" notification when there are no records #52272
+19
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading association records, Active Record unnecessary and confusingly triggers an
instantiation.active_record
notification even when there are no records.This is not happening when loading records from a regular empty relation
rails/activerecord/lib/active_record/relation.rb
Lines 1441 to 1442 in 4fa5681
I found this bug when subscribed to that event and got a strange payload with 0 count: