Skip to content

Guides CSS to format code tags in h2 headings [ci skip] #52276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

andycroll
Copy link
Contributor

@andycroll andycroll commented Jul 5, 2024

Motivation / Background

Noticed when reading the edge guides that we have some wonky formatting for the case when we use a method name in an h2 heading.

There's already a fix for h3-level headings, so I copied the font-weight (400) and eyeballed a font-size. 2.25rem looked too much to my eyes, so went with 2rem.

Detail

This Pull Request changes CSS for the guides. To add h2 code formatting to bring the visual size into line.

Additional information

Before:

before

After:

after

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

Noticed when reading the edge guides that we have some wonky formatting for the case when we use a method name in an h2 heading.

There's already a fix for h3-level headings, so I copied the font-weight (400) and eyeballed a font-size. 2.25rem looked too much to my eyes, so went with 2rem.
@rails-bot rails-bot bot added the docs label Jul 5, 2024
@andycroll andycroll changed the title Guides CSS to format code tags in h2 headings [ci-skip] Guides CSS to format code tags in h2 headings [ci skip] Jul 5, 2024
@p8 p8 added the ready PRs ready to merge label Jul 5, 2024
@p8
Copy link
Member

p8 commented Jul 5, 2024

Thanks @andycroll !

@eileencodes eileencodes merged commit 99fd4c0 into rails:main Jul 10, 2024
2 of 3 checks passed
@andycroll andycroll deleted the guides-h2-code-css branch July 12, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs ready PRs ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants