Change human_attribute_name to raise an error iff in strict mode #52487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
willianveiga
reviewed
Aug 2, 2024
byroot
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
LGTM, it's mosty a question of how much we want to "advertise" this.
@ghiculescu any opinions?
railties/lib/rails/generators/rails/app/templates/config/environments/test.rb.tt
Outdated
Show resolved
Hide resolved
MatheusRich
reviewed
Aug 2, 2024
|
This looks good to me. I agree with not changing the defaults in the template files. |
Problem: f6c0a35 changed `human_attribute_name` to raise error if `raise_on_missing_translations` is `true`. This change had a major impact on existing applications (i.e., too many missing translation errors). Solution: Change `human_attribute_name` to raise an error iff `raise_on_missing_translations` is `:strict`.
shouichi
force-pushed
the
raise-on-missing-translations-strict
branch
from
40549eb to
8b511de
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
f6c0a35 changed
human_attribute_nameto raise error ifraise_on_missing_translationsistrue. This change had a major impact on existing applications (i.e., too many missing translation errors).Solution:
Change
human_attribute_nameto raise an error iffraise_on_missing_translationsis:strict.