Fix ActiveRecord::Base.inspect to correctly indicate how to load schema #52613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: rails#52601 Now that Active Record connections are fully lazy, just calling `.lease_connection` isn't actually enough to estalish a connection. We might as well suggest to use a method with the actual intent.
byroot
force-pushed
the
fix-ar-base-lazy-schema-message
branch
from
7a0b2d5 to
278ebf5
Compare
byroot
added a commit
that referenced
this pull request
Aug 15, 2024
Fix ActiveRecord::Base.inspect to correctly indicate how to load schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #52601
Now that Active Record connections are fully lazy, just calling
.lease_connectionisn't actually enough to estalish a connection.We might as well suggest to use a method with the actual intent.
Need to backport to 7.2.