Fix Devcontainer generator with --dev option path error #52705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
railties/lib/rails/generators/rails/devcontainer/devcontainer_generator.rb
Show resolved
Hide resolved
thejonroberts
force-pushed
the
devcontainer-generator-dev-flag-error
branch
from
9f32df7 to
673feaf
Compare
thejonroberts
commented
Aug 25, 2024
thejonroberts
force-pushed
the
devcontainer-generator-dev-flag-error
branch
from
673feaf to
2f27b66
Compare
n-rodriguez
reviewed
Aug 25, 2024
|
Tests for the rest of the generator functionality should probably be added to the new test file? |
thejonroberts
force-pushed
the
devcontainer-generator-dev-flag-error
branch
from
2f27b66 to
3ad802a
Compare
The devcontainer generator functionality looks like it has been pretty extensively (albeit indirectly) tested in If you are suggesting that you want to move (or copy/share) those tests over to your new test file, to me (with limited knowledge of this codebase's best practices) the PR looks good as is. There are just enough tests for some sanity checks and testing that the bug has been fixed. |
thejonroberts
force-pushed
the
devcontainer-generator-dev-flag-error
branch
2 times, most recently
from
1aca997 to
dfc38cb
Compare
thejonroberts
force-pushed
the
devcontainer-generator-dev-flag-error
branch
3 times, most recently
from
3f89a06 to
3681358
Compare
|
This looks good to me. Thanks =) |
rafaelfranca
force-pushed
the
devcontainer-generator-dev-flag-error
branch
from
3681358 to
7accd04
Compare
Devcontainer generator errors with uninitialized constant Rails::Generators::RAILS_DEV_PATH, which is defined with AppGenerator in .../generators/rails/app/app_generator.rb. Move definition to rails/generators. Co-authored-by: Jerome Dalbert <jerome.dalbert@gmail.com>
rafaelfranca
force-pushed
the
devcontainer-generator-dev-flag-error
branch
from
7accd04 to
cd6e5d6
Compare
rafaelfranca
added a commit
that referenced
this pull request
Aug 27, 2024
…ev-flag-error Fix Devcontainer generator with --dev option path error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixes #52704
This Pull Request has been created because the devcontainer generator with the --dev option fails (
rails g devcontainer --dev). The app generator --dev works just fine.Detail
This Pull request moves the
Rails::Generators::RAILS_DEV_PATHdefinition to Rails::Generators module rather than adding it to Rails::Generators in AppGenerator definition. It also creates a DEV_RAILS_PATH constant inrailties/test/generators/generators_test_helper.rb, so that it can be used consistently in tests.Additional information
rails generateusage, though it is well tested via app generator. I added tests for the dev option behavior only. I can work on full specs, but will keep it separate from this.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]