Skip to content

Link to all methods from ActiveModel::Conversion comments [ci skip] #53157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

mjankowski
Copy link
Contributor

These methods are auto-linked as written, but the trailing punctuation stops the final one in the list from being linked:

Screenshot 2024-10-02 at 20 41 04

Explicit method link style corrects:

Screenshot 2024-10-02 at 20 40 42

@rails-bot rails-bot bot added the activemodel label Oct 3, 2024
@sikachu sikachu added the docs label Oct 3, 2024
Copy link
Member

@sikachu sikachu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this by generating documentation locally, and can confirm that #to_partial_path is now a proper link after this change.

Thank you for the patch!

@sikachu sikachu merged commit 6df3358 into rails:main Oct 3, 2024
3 checks passed
@mjankowski mjankowski deleted the activemodel-conversion-doc-links branch October 3, 2024 01:56
@zzak
Copy link
Member

zzak commented Oct 4, 2024

@sikachu FYI we have a docs-preview for this purpose:
https://0fe738d7.rails-docs-preview.pages.dev/api/classes/ActiveModel/Conversion

@sikachu
Copy link
Member

sikachu commented Oct 4, 2024

@zzak that's good to know, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants