Skip to content

Conversation

wakairo
Copy link
Contributor

@wakairo wakairo commented Oct 6, 2024

Motivation / Background

This Pull Request has been created because there are two different migration file name formats as below.

  • db/migrate/<timestamp>_create_articles.rb
  • db/migrate/20140120201010_create_comments.rb with a comment: "your name will include a different timestamp"

Detail

This Pull Request unifies the format as below.

  • db/migrate/<timestamp>_create_articles.rb
  • db/migrate/<timestamp>_create_comments.rb

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the docs label Oct 6, 2024
@skipkayhil skipkayhil merged commit f9ec1ae into rails:main Oct 12, 2024
3 checks passed
@skipkayhil
Copy link
Member

Thanks!

skipkayhil added a commit that referenced this pull request Oct 12, 2024
…ats_in_getting_started

Unify migration file name formats in "Getting Started with Rails" [ci skip]
skipkayhil added a commit that referenced this pull request Oct 12, 2024
…ats_in_getting_started

Unify migration file name formats in "Getting Started with Rails" [ci skip]
@Ridhwana Ridhwana mentioned this pull request Aug 9, 2025
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants