Fix unintended guide chapter scrolling when visit by turbo [skip ci] #53283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
step to reproduce
Ruby.on.Rails.Guides.-.Google.Chrome.2024-10-13.04-14-09.mp4
When visiting a guide page by turbo, the navHighlight function fires the
scrollIntoView
API.Then, the chapter scrolls to the end of the chapter list by the
updateHighlight
function because IntersectionObserver's time origin is the first page loaded.Detail
To fix this, add "is the page navigated by directly" to the condition of the call
updateHighlight
function.Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]